New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add /rule_engine
API endpoint
#10336
Merged
sstrigler
merged 9 commits into
emqx:master
from
sstrigler:EMQX-8507-rule-engine-need-a-new-api-to-crud-rule-engines-setting-configs
Apr 12, 2023
Merged
feat: add /rule_engine
API endpoint
#10336
sstrigler
merged 9 commits into
emqx:master
from
sstrigler:EMQX-8507-rule-engine-need-a-new-api-to-crud-rule-engines-setting-configs
Apr 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sstrigler
force-pushed
the
EMQX-8507-rule-engine-need-a-new-api-to-crud-rule-engines-setting-configs
branch
from
April 5, 2023 13:19
9c6290a
to
aea870f
Compare
kjellwinblad
previously approved these changes
Apr 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
zmstone
reviewed
Apr 5, 2023
zmstone
reviewed
Apr 5, 2023
zmstone
reviewed
Apr 5, 2023
zmstone
reviewed
Apr 5, 2023
zmstone
previously approved these changes
Apr 5, 2023
thalesmg
previously approved these changes
Apr 5, 2023
LenaLenaPan
reviewed
Apr 6, 2023
LenaLenaPan
reviewed
Apr 6, 2023
LenaLenaPan
reviewed
Apr 6, 2023
Co-authored-by: LenaLenaPan <120552185+LenaLenaPan@users.noreply.github.com>
sstrigler
force-pushed
the
EMQX-8507-rule-engine-need-a-new-api-to-crud-rule-engines-setting-configs
branch
from
April 11, 2023 10:04
bf82d7f
to
8ef36f2
Compare
Pull Request Test Coverage Report for Build 4668222089
馃挍 - Coveralls |
thalesmg
approved these changes
Apr 11, 2023
sstrigler
deleted the
EMQX-8507-rule-engine-need-a-new-api-to-crud-rule-engines-setting-configs
branch
April 12, 2023 09:44
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://emqx.atlassian.net/browse/EMQX-8507
Summary
馃 Generated by Copilot at 9c6290a
This pull request adds a new feature to the rule engine API, which allows users to get and update the rule engine configuration via the
/rule_engine
endpoint. It also enhances the rule engine configuration schema by adding a reference field and a helper function. The pull request updates the swagger documentation, the localization files, the changelog, and the test suite accordingly.PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
changes/{ce,ee}/(feat|perf|fix)-<PR-id>.en.md
files