Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: hiden auto_subscribe conf #10381

Merged
merged 4 commits into from Apr 13, 2023

Conversation

zhongwencool
Copy link
Member

@zhongwencool zhongwencool commented Apr 13, 2023

Fixes EMQX-9505

Hide the auto_subscribe in configuration file, so that it can be modified only through the HTTP API.

Summary

馃 Generated by Copilot at a70930f

The pull request hides the auto_subscribe configuration fields from the default view and updates the version of the emqx_auto_subscribe application. This improves the user experience and maintains the version consistency.

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Changed lines covered in coverage report
  • Change log has been added to changes/{ce,ee}/(feat|perf|fix)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • If there should be document changes, a PR to emqx-docs.git is sent, or a jira ticket is created to follow up
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

@zhongwencool zhongwencool requested a review from a team as a code owner April 13, 2023 01:47
@coveralls
Copy link
Collaborator

coveralls commented Apr 13, 2023

Pull Request Test Coverage Report for Build 4685050591

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 42 unchanged lines in 16 files lost coverage.
  • Overall coverage decreased (-0.04%) to 81.116%

Files with Coverage Reduction New Missed Lines %
apps/emqx_bridge/src/emqx_bridge.erl 1 91.2%
apps/emqx_modules/src/emqx_delayed.erl 1 94.78%
apps/emqx/src/emqx_broker.erl 1 88.2%
apps/emqx/src/emqx_flapping.erl 1 85.11%
apps/emqx/src/emqx_listeners.erl 1 87.18%
apps/emqx/src/emqx_message.erl 1 94.83%
apps/emqx/src/emqx_session.erl 1 87.65%
apps/emqx/src/emqx_stats.erl 1 93.33%
apps/emqx/src/emqx_sys_mon.erl 1 91.67%
apps/emqx/src/emqx_cm.erl 2 91.44%
Totals Coverage Status
Change from base Build 4680037970: -0.04%
Covered Lines: 25314
Relevant Lines: 31207

馃挍 - Coveralls

HJianBo
HJianBo previously approved these changes Apr 13, 2023
Co-authored-by: JianBo He <heeejianbo@163.com>
Copy link
Member

@HJianBo HJianBo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhongwencool zhongwencool merged commit cf2f00c into emqx:master Apr 13, 2023
39 checks passed
@zhongwencool zhongwencool deleted the hiden-auto-subscribe-conf branch December 15, 2023 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants