New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: emqx_schema: comma_separated_atoms() type cannot be configured as a list #10389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhongwencool
force-pushed
the
core-nodes-array
branch
from
April 13, 2023 12:26
1472a37
to
a7ab7bf
Compare
thalesmg
previously approved these changes
Apr 13, 2023
thalesmg
previously approved these changes
Apr 13, 2023
@zmstone something wrong when using hocon
|
I think the latest hocon has this breaking change: emqx/hocon#244 |
zhongwencool
force-pushed
the
core-nodes-array
branch
from
April 14, 2023 13:42
fb28a3a
to
85b37a8
Compare
zhongwencool
force-pushed
the
core-nodes-array
branch
2 times, most recently
from
April 18, 2023 01:31
3656b30
to
6ba1ec5
Compare
Co-authored-by: Thales Macedo Garitezi <thalesmg@gmail.com>
zhongwencool
force-pushed
the
core-nodes-array
branch
from
April 18, 2023 01:34
6ba1ec5
to
ad3e529
Compare
Pull Request Test Coverage Report for Build 4727601091
馃挍 - Coveralls |
HJianBo
reviewed
Apr 18, 2023
Co-authored-by: JianBo He <heeejianbo@163.com>
HJianBo
reviewed
Apr 18, 2023
HJianBo
approved these changes
Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes EMQX-9005
Summary
馃 Generated by Copilot at 1472a37
This pull request updates the cluster configuration schema and tests to allow more flexible node name formats. It also updates the hocon dependency to enable this feature.
PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
changes/{ce,ee}/(feat|perf|fix)-<PR-id>.en.md
filesChecklist for CI (.github/workflows) changes
changes/
dir for user-facing artifacts update