New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(schema_registry): add support for protobuf schemas #10409
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thalesmg
force-pushed
the
protobuf-schema-v50
branch
from
April 14, 2023 20:36
8f7c584
to
4cff399
Compare
thalesmg
commented
Apr 14, 2023
echo "gpb should not be included in the release" | ||
exit 1 | ||
fi | ||
: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thalesmg
force-pushed
the
protobuf-schema-v50
branch
2 times, most recently
from
April 14, 2023 20:58
617b854
to
e65903e
Compare
ieQu1
previously approved these changes
Apr 17, 2023
thalesmg
force-pushed
the
protobuf-schema-v50
branch
from
April 17, 2023 16:05
e65903e
to
9d15247
Compare
Had to rebase to fix conflicts in the i18n files. |
ieQu1
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://emqx.atlassian.net/browse/EMQX-9470
Summary
馃 Generated by Copilot at 8f7c584
This pull request adds support for protobuf schemas and serdes in the schema registry app, using the gpb library and dynamic module loading. It also updates the test suites, the HTTP API, the i18n file, and the build script to handle the new feature.
PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
changes/{ce,ee}/(feat|perf|fix)-<PR-id>.en.md
filesChecklist for CI (.github/workflows) changes
changes/
dir for user-facing artifacts update