Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: deprecate statsd #10457

Merged
merged 2 commits into from Apr 20, 2023
Merged

chore: deprecate statsd #10457

merged 2 commits into from Apr 20, 2023

Conversation

HJianBo
Copy link
Member

@HJianBo HJianBo commented Apr 20, 2023

Fixes https://emqx.atlassian.net/browse/EMQX-9313

We have decided to abolish this feature, so in version 5.0 we have hidden the configuration document and marked the related HTTP API as deprecated.

Summary

馃 Generated by Copilot at 712f7b7

Deprecated the statsd plugin and hid its configuration from the hocon schema. Modified emqx_statsd_api.erl and emqx_statsd_schema.erl to reflect this change.

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Changed lines covered in coverage report
  • Change log has been added to changes/{ce,ee}/(feat|perf|fix)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • If there should be document changes, a PR to emqx-docs.git is sent, or a jira ticket is created to follow up
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

@HJianBo HJianBo marked this pull request as ready for review April 20, 2023 06:25
@HJianBo HJianBo requested review from a team and JimMoen as code owners April 20, 2023 06:25
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 4751198620

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 44 unchanged lines in 14 files lost coverage.
  • Overall coverage decreased (-0.04%) to 81.239%

Files with Coverage Reduction New Missed Lines %
apps/emqx_bridge/src/emqx_bridge.erl 1 91.27%
apps/emqx_gateway_mqttsn/src/emqx_mqttsn_channel.erl 1 73.13%
apps/emqx/src/emqx_broker.erl 1 85.96%
apps/emqx/src/emqx_flapping.erl 1 87.27%
apps/emqx/src/emqx_logger_textfmt.erl 1 59.09%
apps/emqx_resource/src/emqx_resource_buffer_worker.erl 2 94.57%
apps/emqx/src/emqx_cm.erl 2 91.44%
apps/emqx/src/emqx_session.erl 2 87.25%
apps/emqx/src/emqx_stats.erl 2 91.67%
apps/emqx_gateway_exproto/src/emqx_exproto_gcli.erl 3 48.78%
Totals Coverage Status
Change from base Build 4745034971: -0.04%
Covered Lines: 25596
Relevant Lines: 31507

馃挍 - Coveralls

@zhongwencool zhongwencool merged commit 72685be into emqx:master Apr 20, 2023
124 of 125 checks passed
@HJianBo HJianBo deleted the hide-statsd branch April 20, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants