Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(emqx_bridge): validate Webhook bad URL #10463

Merged

Conversation

SergeTupchiy
Copy link
Contributor

@SergeTupchiy SergeTupchiy commented Apr 20, 2023

Error messages:
Screenshot from 2023-04-20 15-13-23
Screenshot from 2023-04-20 15-19-43

Fixes: EMQX-9310

Summary

🤖 Generated by Copilot at acbdb1f

This pull request enhances the error handling and validation of bridge configuration data and URLs in the emqx_bridge application. It also adds test cases for the bridge API endpoints and updates the application version to 0.1.17.

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Changed lines covered in coverage report
  • Change log has been added to changes/{ce,ee}/(feat|perf|fix)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • If there should be document changes, a PR to emqx-docs.git is sent, or a jira ticket is created to follow up
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

@SergeTupchiy SergeTupchiy requested a review from a team as a code owner April 20, 2023 13:49
@SergeTupchiy SergeTupchiy force-pushed the EMQX-9310-webhook-port-validation branch from acbdb1f to ba32172 Compare April 20, 2023 13:57
thalesmg
thalesmg previously approved these changes Apr 20, 2023
apps/emqx_bridge/src/emqx_bridge_resource.erl Show resolved Hide resolved
@SergeTupchiy SergeTupchiy merged commit 0b105dc into emqx:master Apr 20, 2023
123 of 124 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants