Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(limiter): remove the default limit of connect rate #10490

Merged
merged 2 commits into from Apr 24, 2023

Conversation

lafirest
Copy link
Member

@lafirest lafirest commented Apr 24, 2023

Remove the default limit of connect rate which used to be 1000/s.

Summary

馃 Generated by Copilot at 7b51a49

Simplified the schema for listener buckets in emqx_limiter_schema.erl by using a single bucket_opts field. This improves the readability and configurability of the limiter settings.

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Changed lines covered in coverage report
  • Change log has been added to changes/{ce,ee}/(feat|perf|fix)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • If there should be document changes, a PR to emqx-docs.git is sent, or a jira ticket is created to follow up
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

@lafirest lafirest marked this pull request as ready for review April 24, 2023 06:19
@lafirest lafirest requested a review from a team as a code owner April 24, 2023 06:19
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 4783111000

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 34 unchanged lines in 10 files lost coverage.
  • Overall coverage decreased (-0.05%) to 81.144%

Files with Coverage Reduction New Missed Lines %
apps/emqx_gateway/src/emqx_gateway_schema.erl 1 88.89%
apps/emqx/src/emqx_limiter/src/emqx_limiter_server.erl 1 88.62%
apps/emqx/src/emqx_quic_data_stream.erl 1 75.21%
lib-ee/emqx_ee_connector/src/emqx_ee_connector_dynamo.erl 1 69.41%
apps/emqx_resource/src/emqx_resource_manager.erl 2 88.56%
apps/emqx/src/emqx_alarm.erl 2 88.24%
apps/emqx/src/emqx_channel.erl 2 87.33%
apps/emqx_resource/src/emqx_resource_buffer_worker.erl 3 94.42%
apps/emqx_resource/src/emqx_resource_metrics.erl 5 77.78%
apps/emqx/src/emqx_reason_codes.erl 16 85.29%
Totals Coverage Status
Change from base Build 4777157010: -0.05%
Covered Lines: 25674
Relevant Lines: 31640

馃挍 - Coveralls

@lafirest lafirest merged commit 2845469 into emqx:master Apr 24, 2023
139 of 141 checks passed
@lafirest lafirest deleted the fix/rmv_def_conn_limit branch April 24, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants