Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rename etcd.ssl to etcd.ssl_options #10491

Merged
merged 2 commits into from Apr 25, 2023

Conversation

zhongwencool
Copy link
Member

@zhongwencool zhongwencool commented Apr 24, 2023

Fixes EMQX-9671
Keep all of SSL options consistent in the configuration file (not include the listener)

Summary

馃 Generated by Copilot at 0b1a2dd

Refactored SSL configuration for etcd cluster and bumped emqx_conf version. Renamed ssl field to ssl_options in emqx_conf_schema.erl and added an alias for backward compatibility.

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Changed lines covered in coverage report
  • Change log has been added to changes/{ce,ee}/(feat|perf|fix)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • If there should be document changes, a PR to emqx-docs.git is sent, or a jira ticket is created to follow up
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

@zhongwencool zhongwencool requested a review from a team as a code owner April 24, 2023 06:43
@zhongwencool zhongwencool merged commit 79a235f into emqx:master Apr 25, 2023
139 of 140 checks passed
@zhongwencool zhongwencool deleted the rename-etcd-ssl-to-ssl_options branch April 25, 2023 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants