New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(oracle): Oracle Database integration #10498
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thalesmg
reviewed
Apr 24, 2023
paulozulato
force-pushed
the
master
branch
4 times, most recently
from
April 25, 2023 01:14
f76cbf9
to
2f9db0f
Compare
zmstone
reviewed
Apr 25, 2023
zmstone
reviewed
Apr 26, 2023
zmstone
reviewed
Apr 26, 2023
zmstone
reviewed
Apr 26, 2023
zmstone
reviewed
Apr 26, 2023
zmstone
reviewed
Apr 26, 2023
zmstone
reviewed
Apr 26, 2023
zmstone
reviewed
Apr 26, 2023
zmstone
reviewed
Apr 26, 2023
savonarola
reviewed
Apr 26, 2023
zmstone
reviewed
Apr 26, 2023
zmstone
reviewed
Apr 26, 2023
paulozulato
force-pushed
the
master
branch
2 times, most recently
from
April 26, 2023 17:14
fcd5924
to
5bea536
Compare
paulozulato
force-pushed
the
master
branch
2 times, most recently
from
April 26, 2023 18:34
4d61c96
to
a6c1143
Compare
thalesmg
reviewed
Apr 26, 2023
Pull Request Test Coverage Report for Build 4820335382
💛 - Coveralls |
paulozulato
force-pushed
the
master
branch
2 times, most recently
from
April 27, 2023 13:25
0041079
to
c211a0e
Compare
jamdb_oracle does not provide interface for performing async queries and ecpool does not monitor the worker which calls jamdb_oracle, so it's safer to keep support for sync queries only.
thalesmg
approved these changes
Apr 27, 2023
ieQu1
approved these changes
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://emqx.atlassian.net/browse/EMQX-9341
Summary
🤖 Generated by Copilot at 0f39230
This pull request adds a new feature to the emqx project: the Oracle Database bridge, which allows emqx to connect to and exchange messages with Oracle Database. It introduces two new applications:
emqx_oracle
, which provides the Oracle Database connector, andemqx_bridge_oracle
, which provides the bridge configuration and logic. It also updates some existing applications, such asemqx_limiter
,emqx_bridge
, andemqx_connector
, to support the new feature. It also adds some docker-compose files and common test files for testing the feature.PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
changes/{ce,ee}/(feat|perf|fix)-<PR-id>.en.md
filesSchema changes are backward compatibleChecklist for CI (.github/workflows) changes
If changed package build workflow, pass [this action](https://github.com/emqx/emqx/actions/workflows/build_packages.yaml) (manual trigger)Change log has been added tochanges/
dir for user-facing artifacts update