Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add shutdown count #10568

Merged
merged 1 commit into from May 8, 2023
Merged

Conversation

paulozulato
Copy link
Contributor

@paulozulato paulozulato commented May 1, 2023

Fixes https://emqx.atlassian.net/browse/EMQX-9008
Fixes https://emqx.atlassian.net/browse/EMQX-9219

Summary

馃 Generated by Copilot at ebdcad5

Added a feature to show the number of clients disconnected by the broker due to invalid topic filters or protocol errors. This feature involves changes to the emqx_mgmt_cli, emqx_listeners, and emqx_client_SUITE modules, as well as a minor version bump in emqx.app.src.

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Changed lines covered in coverage report
  • Change log has been added to changes/{ce,ee}/(feat|perf|fix)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • If there should be document changes, a PR to emqx-docs.git is sent, or a jira ticket is created to follow up
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

@coveralls
Copy link
Collaborator

coveralls commented May 2, 2023

Pull Request Test Coverage Report for Build 4877448429

  • 3 of 8 (37.5%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 81.601%

Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/emqx/src/emqx_listeners.erl 3 5 60.0%
apps/emqx_management/src/emqx_mgmt_cli.erl 0 3 0.0%
Totals Coverage Status
Change from base Build 4873366016: -0.03%
Covered Lines: 26096
Relevant Lines: 31980

馃挍 - Coveralls

@paulozulato paulozulato marked this pull request as ready for review May 2, 2023 11:55
@paulozulato paulozulato requested review from a team, lafirest and sstrigler as code owners May 2, 2023 11:55
@paulozulato paulozulato merged commit 83c4b2f into emqx:master May 8, 2023
149 of 150 checks passed
@paulozulato paulozulato deleted the feat-shutdown-count branch May 8, 2023 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants