Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0504 delete statsd all together #10600

Merged
merged 2 commits into from
May 26, 2023

Conversation

zmstone
Copy link
Member

@zmstone zmstone commented May 4, 2023

Fixes https://emqx.atlassian.net/browse/EMQX-9313

Summary

🤖 Generated by Copilot at 3085ded

This pull request removes the emqx_statsd application from the EMQ X Broker, as it is no longer needed or maintained. It deletes all the files related to the application, and updates the modules that depend on or reference it. It also improves the static analysis of the broker APIs by ignoring some deleted modules and providing more error information.

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • [~] Added tests for the changes
  • [~] Changed lines covered in coverage report
  • Change log has been added to changes/{ce,ee}/(feat|perf|fix)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • [~] If there should be document changes, a PR to emqx-docs.git is sent, or a jira ticket is created to follow up
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • [~] If changed package build workflow, pass this action (manual trigger)
  • [~] Change log has been added to changes/ dir for user-facing artifacts update

@zmstone zmstone requested review from a team, JimMoen and lafirest as code owners May 4, 2023 12:55
@zmstone zmstone force-pushed the 0504-delete-statsd-all-together branch from 24f0356 to 1abf961 Compare May 4, 2023 16:38
lafirest
lafirest previously approved these changes May 5, 2023
@zmstone zmstone force-pushed the 0504-delete-statsd-all-together branch from 073e21e to 72da3af Compare May 26, 2023 13:18
Copy link
Contributor

@thalesmg thalesmg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@zmstone zmstone merged commit fe81e95 into emqx:master May 26, 2023
164 checks passed
@zmstone zmstone deleted the 0504-delete-statsd-all-together branch May 26, 2023 14:30
@yanzhiemq
Copy link
Collaborator

yanzhiemq commented Jun 13, 2023

Bug Fixes

  • Deleted emqx_statsd application.

@yanzhiemq
Copy link
Collaborator

yanzhiemq commented Jun 13, 2023

修复

  • 删除了 emqx_statsd 应用。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants