New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(limiter): simplify limiter configuration #10625
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lafirest
force-pushed
the
refactor/limiter_cfg
branch
2 times, most recently
from
May 6, 2023 09:13
68d7087
to
c60b57e
Compare
Pull Request Test Coverage Report for Build 4911194714
馃挍 - Coveralls |
lafirest
force-pushed
the
refactor/limiter_cfg
branch
from
May 8, 2023 03:46
c60b57e
to
197ebcc
Compare
HJianBo
approved these changes
May 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
HJianBo
reviewed
May 15, 2023
@@ -0,0 +1,4 @@ | |||
Simplify limiter configuration. | |||
- Reduce the complexity of the limiter's configuration. | |||
e.g. now users can use `limiter.messages_rate = 1000/s` to quickly set the node-level limit for the message publish. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
limiter.messages_rate = "1000/s"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes EMQX-9813
after this refactor, the way to set node-level setting changed to:
for listener-level:
Summary
馃 Generated by Copilot at 65228ec
Added a new HTTP API endpoint and a short path configuration feature for the node-level and listener-level rate limiter settings. Modified the
emqx_limiter_schema
,emqx_schema
, andemqx_listeners
modules to support the new features. Added and updated the i18n files for the limiter settings. Added test cases for the short path configuration feature.PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
changes/{ce,ee}/(feat|perf|fix)-<PR-id>.en.md
filesChecklist for CI (.github/workflows) changes
changes/
dir for user-facing artifacts update