Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(TLS): veriy client cert keyusage #10669

Merged
merged 6 commits into from May 17, 2023

Conversation

qzhuyan
Copy link
Contributor

@qzhuyan qzhuyan commented May 11, 2023

Fixes EMQX-9790

Summary

馃 Generated by Copilot at 4da137c

This pull request adds a new SSL verification option for listeners, verify_peer_ext_key_usage, which allows the user to specify extended key usage values for the peer certificate. It implements this option in the emqx_const_v2, emqx_tls_lib, and emqx_listeners modules, and adds a new test suite emqx_listener_tls_verify_keyusage_SUITE to verify its functionality. It also modifies the emqx_test_tls_certs_helper module to support generating certificates with different extensions and key usages.

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Changed lines covered in coverage report
  • Change log has been added to changes/{ce,ee}/(feat|perf|fix)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • If there should be document changes, a PR to emqx-docs.git is sent, or a jira ticket is created to follow up
  • Schema changes are backward compatible

@qzhuyan qzhuyan force-pushed the dev/william/tls-verify-keyusages branch from 28177c2 to 64955e9 Compare May 12, 2023 09:37
@qzhuyan qzhuyan marked this pull request as ready for review May 12, 2023 10:13
@qzhuyan qzhuyan requested a review from a team as a code owner May 12, 2023 10:13
@qzhuyan qzhuyan changed the title Dev/william/tls verify keyusages feat(TLS): veriy client cert keyusage May 12, 2023
@coveralls
Copy link
Collaborator

coveralls commented May 12, 2023

Pull Request Test Coverage Report for Build 4960883701

  • 32 of 34 (94.12%) changed or added relevant lines in 3 files are covered.
  • 24 unchanged lines in 5 files lost coverage.
  • Overall coverage increased (+0.03%) to 74.882%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/emqx_const_v2.erl 24 25 96.0%
src/emqx_tls_lib.erl 6 7 85.71%
Files with Coverage Reduction New Missed Lines %
apps/emqx_rule_engine/src/emqx_rule_engine.erl 1 70.72%
src/emqx_cm.erl 3 80.1%
src/emqx_sys_mon.erl 3 88.73%
apps/emqx_management/src/emqx_mgmt_data_backup.erl 8 66.03%
src/emqx_reason_codes.erl 9 90.0%
Totals Coverage Status
Change from base Build 4957394324: 0.03%
Covered Lines: 14864
Relevant Lines: 19850

馃挍 - Coveralls

@qzhuyan qzhuyan merged commit 4a476be into emqx:main-v4.4 May 17, 2023
134 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants