Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update the will message timestamp when it is ready to publish #10682

Merged
merged 2 commits into from May 12, 2023

Conversation

lafirest
Copy link
Member

@lafirest lafirest commented May 12, 2023

Fixes #10680

Summary

🤖 Generated by Copilot at dcd4640

Add message tracing support to emqx_channel.erl. This module publishes messages to the broker with a timestamp field for latency measurement.

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Changed lines covered in coverage report
  • Change log has been added to changes/{ce,ee}/(feat|perf|fix)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • If there should be document changes, a PR to emqx-docs.git is sent, or a jira ticket is created to follow up
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

@lafirest lafirest marked this pull request as ready for review May 12, 2023 06:47
@lafirest lafirest requested a review from a team as a code owner May 12, 2023 06:47
@lafirest lafirest marked this pull request as draft May 12, 2023 07:21
@lafirest lafirest marked this pull request as ready for review May 12, 2023 08:51
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 4956612789

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 43 unchanged lines in 14 files lost coverage.
  • Overall coverage decreased (-0.04%) to 81.526%

Files with Coverage Reduction New Missed Lines %
apps/emqx_management/src/emqx_mgmt_util.erl 1 13.79%
apps/emqx/src/emqx_broker_helper.erl 1 90.7%
apps/emqx/src/emqx_channel.erl 1 87.5%
apps/emqx/src/emqx_cm.erl 1 90.99%
apps/emqx/src/emqx_limiter/src/emqx_limiter_server.erl 1 90.21%
apps/emqx/src/emqx_session.erl 1 87.65%
apps/emqx_resource/src/emqx_resource_buffer_worker.erl 2 94.43%
apps/emqx/src/emqx_alarm.erl 2 89.92%
apps/emqx/src/emqx_banned.erl 2 89.39%
apps/emqx_gateway_exproto/src/emqx_exproto_gcli.erl 3 48.78%
Totals Coverage Status
Change from base Build 4954396099: -0.04%
Covered Lines: 26231
Relevant Lines: 32175

💛 - Coveralls

@lafirest lafirest merged commit 67ada52 into emqx:master May 12, 2023
153 of 154 checks passed
@lafirest lafirest deleted the fix/will_msg_timestamp branch May 12, 2023 14:25
@yanzhiemq
Copy link
Collaborator

yanzhiemq commented Jun 13, 2023

Bug Fixes

  • Fixed the timestamp for the will message is incorrectly assigned at the session creation time, now this timestamp is the disconnected time of the session.

@yanzhiemq
Copy link
Collaborator

yanzhiemq commented Jun 13, 2023

修复

  • 修正了在会话创建时为遗嘱消息赋予时间戳这个错误,现在该时间戳为会话断开时间。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The timestamp of the will message is wrong
4 participants