fix(limiter): adjust type for compatibility #10686
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
this type used to be
0 | float
, but here https://github.com/emqx/emqx/blob/d1089fa4603fddd7035a8487515fcabe496acdfa/apps/emqx/src/emqx_limiter/src/emqx_limiter_schema.erl#LL144C68-L144C68, we set a default value of 1000 to the capacity, it should have been stored as a string, but in some configuration files it is a number which will not trigger atyperefl_from_string
call and directly pass to the hocon validator, obviously, the 1000 either 0 or float, so the type must be changed tonumber()
.Summary
馃 Generated by Copilot at 95a67f3
Changed the type of
burst_rate
inemqx_limiter_schema.erl
to support negative values. This allows the rate limiter to borrow tokens from the future.PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
changes/{ce,ee}/(feat|perf|fix)-<PR-id>.en.md
filesChecklist for CI (.github/workflows) changes
changes/
dir for user-facing artifacts update