Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(config): enforcing atom key path in hotcode path #10698

Merged
merged 4 commits into from May 22, 2023

Conversation

qzhuyan
Copy link
Contributor

@qzhuyan qzhuyan commented May 14, 2023

Fixes EMQX-9618

Summary

🤖 Generated by Copilot at a8cfebe

Refactored and optimized runtime configuration access in emqx_config.erl. Used a consistent type of runtime_config_key_path() and removed redundant code.

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Changed lines covered in coverage report
  • Change log has been added to changes/{ce,ee}/(feat|perf|fix)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • If there should be document changes, a PR to emqx-docs.git is sent, or a jira ticket is created to follow up
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

@qzhuyan qzhuyan changed the title perf(config): enforcing atom key key path in hotcode path perf(config): enforcing atom key path in hotcode path May 14, 2023
@qzhuyan qzhuyan force-pushed the perf/william/force-atom-conf-path branch 6 times, most recently from 42ab5be to 54bb595 Compare May 15, 2023 14:47
@qzhuyan qzhuyan force-pushed the perf/william/force-atom-conf-path branch from c617e70 to 1c746ed Compare May 16, 2023 07:57
@coveralls
Copy link
Collaborator

coveralls commented May 16, 2023

Pull Request Test Coverage Report for Build 5001345957

  • 21 of 26 (80.77%) changed or added relevant lines in 7 files are covered.
  • 155 unchanged lines in 23 files lost coverage.
  • Overall coverage decreased (-0.02%) to 81.851%

Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/emqx/src/emqx_config.erl 6 11 54.55%
Files with Coverage Reduction New Missed Lines %
apps/emqx_bridge_dynamo/src/emqx_bridge_dynamo_connector_client.erl 1 65.31%
apps/emqx_conf/src/emqx_conf_schema.erl 1 92.86%
apps/emqx_resource/src/emqx_resource_buffer_worker.erl 1 94.32%
apps/emqx_rule_engine/src/emqx_rule_sqlparser.erl 1 91.67%
apps/emqx/src/emqx_logger.erl 1 80.49%
apps/emqx/src/emqx_message.erl 1 94.83%
apps/emqx/src/emqx_stats.erl 1 91.67%
apps/emqx/src/emqx_sys_mon.erl 1 90.63%
apps/emqx_authz/src/emqx_authz_api_schema.erl 2 96.72%
apps/emqx_gateway_mqttsn/src/emqx_mqttsn_frame.erl 2 63.48%
Totals Coverage Status
Change from base Build 4981883058: -0.02%
Covered Lines: 27127
Relevant Lines: 33142

💛 - Coveralls

@qzhuyan qzhuyan force-pushed the perf/william/force-atom-conf-path branch from 879ed91 to 727ad59 Compare May 17, 2023 14:58
@qzhuyan qzhuyan marked this pull request as ready for review May 17, 2023 16:59
@qzhuyan qzhuyan requested review from a team, JimMoen, savonarola and lafirest as code owners May 17, 2023 16:59
@qzhuyan qzhuyan merged commit e824e1d into emqx:master May 22, 2023
160 checks passed
@yanzhiemq
Copy link
Collaborator

yanzhiemq commented Jun 13, 2023

Enhancements

  • Optimized memory usage when accessing the configuration during runtime.

@yanzhiemq
Copy link
Collaborator

yanzhiemq commented Jun 13, 2023

增强

  • 优化了在运行时访问配置的内存使用。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants