Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pulsar): use a binary duration as default health_check_interval #10707

Merged
merged 1 commit into from
May 15, 2023

Conversation

thalesmg
Copy link
Contributor

@thalesmg thalesmg commented May 15, 2023

Fixes https://emqx.atlassian.net/browse/EMQX-9885

The frontend needs the default value to match the duration (binary) type to display correctly.

Summary

馃 Generated by Copilot at 5960cc5

Changed the default value and format of health_check_interval option for Pulsar bridge plugin. Updated override_default function to support binary values.

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Changed lines covered in coverage report
  • Change log has been added to changes/{ce,ee}/(feat|perf|fix)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • If there should be document changes, a PR to emqx-docs.git is sent, or a jira ticket is created to follow up
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

Fixes https://emqx.atlassian.net/browse/EMQX-9885

The frontend needs the default value to match the duration (binary)
type to display correctly.
@thalesmg thalesmg marked this pull request as ready for review May 15, 2023 12:49
@thalesmg thalesmg requested a review from a team as a code owner May 15, 2023 12:49
@thalesmg thalesmg merged commit f8bf202 into emqx:master May 15, 2023
160 checks passed
@thalesmg thalesmg deleted the fix-pulsar-health-check-default-v50 branch May 15, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants