Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update wehbook's request_timeout into resource_opts #10713

Conversation

zhongwencool
Copy link
Member

@zhongwencool zhongwencool commented May 16, 2023

Fixes EMQX-9822

We hide the request_timeout in resource_option of the webhook to keep it consistent with the http request_timeout of the webhook.
From now on, when configuring a webhook through API or configuration files,
it is no longer necessary to configure the request_timeout of the resource. Only configuring the http request_timeout is sufficient, and the request_timeout in the resource will automatically be consistent with the http request_timeout.

Note: need remove resource_opts's request_timeout from dashboard webhook.

Summary

馃 Generated by Copilot at 7d7c069

This pull request refactors and simplifies the code of the emqx_bridge application, especially the webhook bridge. It introduces a new request_timeout field for the webhook resource, deprecates an old field for the webhook bridge, and updates the version number. It also improves the readability and performance of the emqx_bridge_resource module.

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Changed lines covered in coverage report
  • Change log has been added to changes/{ce,ee}/(feat|perf|fix)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • If there should be document changes, a PR to emqx-docs.git is sent, or a jira ticket is created to follow up
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

@zhongwencool zhongwencool requested a review from a team as a code owner May 16, 2023 07:33
@zhongwencool zhongwencool force-pushed the put-webhook-request-timeout-into-resource-opts branch 2 times, most recently from d4d1000 to 0e15baf Compare May 17, 2023 05:35
@zhongwencool zhongwencool force-pushed the put-webhook-request-timeout-into-resource-opts branch from 0e15baf to 2b99a9b Compare May 17, 2023 05:41
Copy link
Member

@zmstone zmstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me,
Will leave it to @thalesmg for approval.

@zhongwencool zhongwencool merged commit ea8ac87 into emqx:release-50 May 17, 2023
138 checks passed
@zhongwencool zhongwencool deleted the put-webhook-request-timeout-into-resource-opts branch May 17, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants