Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve emqx cm #10729

Merged
merged 4 commits into from
May 18, 2023
Merged

Improve emqx cm #10729

merged 4 commits into from
May 18, 2023

Conversation

terry-xiaoyu
Copy link
Contributor

@terry-xiaoyu terry-xiaoyu commented May 17, 2023

Fixes

Summary

馃 Generated by Copilot at bbe3521

This pull request improves the channel management, websocket connection, and proxy protocol features of emqx by fixing some bugs, enhancing the log messages, and adding a macro for the ekka_locker timeout. It affects the files emqx_cm.erl, emqx_ws_connection.erl, emqx_cm_locker.erl, and emqx_connection.erl.

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Changed lines covered in coverage report
  • Change log has been added to changes/{ce,ee}/(feat|perf|fix)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • If there should be document changes, a PR to emqx-docs.git is sent, or a jira ticket is created to follow up
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

@terry-xiaoyu terry-xiaoyu requested review from qzhuyan and a team as code owners May 17, 2023 06:14
@coveralls
Copy link
Collaborator

coveralls commented May 17, 2023

Pull Request Test Coverage Report for Build 5009382854

  • 6 of 9 (66.67%) changed or added relevant lines in 4 files are covered.
  • 33 unchanged lines in 8 files lost coverage.
  • Overall coverage increased (+0.2%) to 75.02%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/emqx_cm.erl 2 3 66.67%
src/emqx_connection.erl 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
apps/emqx_rule_engine/src/emqx_rule_engine.erl 1 70.72%
src/emqx_const_v2.erl 1 96.77%
src/emqx_broker.erl 2 83.23%
src/emqx_connection.erl 2 91.53%
apps/emqx_web_hook/src/emqx_web_hook.erl 5 93.94%
src/emqx_tls_lib.erl 5 94.38%
src/emqx_reason_codes.erl 6 92.14%
src/emqx_listeners.erl 11 84.07%
Totals Coverage Status
Change from base Build 4957394324: 0.2%
Covered Lines: 14896
Relevant Lines: 19856

馃挍 - Coveralls

@terry-xiaoyu terry-xiaoyu merged commit be0038e into emqx:main-v4.4 May 18, 2023
133 checks passed
@terry-xiaoyu terry-xiaoyu deleted the improve-emqx-cm branch May 18, 2023 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants