fix(bridge_api): don't crash when formatting empty/unknown bridge metrics #10743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thalesmg
force-pushed
the
fix-bridge-metric-aggregation-r50
branch
2 times, most recently
from
997d7a0
to
4b83935
Compare
thalesmg
force-pushed
the
fix-bridge-metric-aggregation-r50
branch
from
4b83935
to
09ea2e2
Compare
zhongwencool
approved these changes
May 19, 2023
|
|
HJianBo
approved these changes
May 19, 2023
8 tasks
thalesmg
added a commit
to thalesmg/emqx
that referenced
this pull request
May 30, 2023
Fixes https://emqx.atlassian.net/browse/EMQX-10073 Fixes emqx#10714 (comment) Similar issue to emqx#10743, but on the rule engine API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
targeting
release-50Fixes https://emqx.atlassian.net/browse/EMQX-9872
Summary
🤖 Generated by Copilot at 3ac08fa
This pull request adds and improves tests for the bridge API in cluster scenarios, and fixes a bug in the
format_metricsfunction that caused errors when a node joined a cluster with existing bridges. It also introduces a new optionjoin_tofor themk_cluster_specsfunction to specify a different node to join the cluster to.PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
changes/{ce,ee}/(feat|perf|fix)-<PR-id>.en.mdfilesChecklist for CI (.github/workflows) changes
changes/dir for user-facing artifacts update