fix: supports test the $events/delivery_dropped event by API
#10746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmstone
reviewed
May 19, 2023
changes/ce/fix-10746.en.md
Outdated
| @@ -0,0 +1 @@ | |||
| Add support for testing the `$events/delivery_dropped` event by the `rule_test` API. | |||
There was a problem hiding this comment.
Suggested change
| Add support for testing the `$events/delivery_dropped` event by the `rule_test` API. | |
| Add missing a missing event rule-engine event `$events/delivery_dropped`. |
There was a problem hiding this comment.
The $events/delivery_dropped isn't missing, this schema only affects the rule_test API which is just for testing an event in the dashboard
zmstone
reviewed
May 19, 2023
do you mean the test cases or the prefix of changlog ? |
I mean |
ieQu1
approved these changes
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes EMQX-9869
Summary
馃 Generated by Copilot at fa799e9
Added a new rule engine event type for delivery dropped events. Updated the
ctx_eventschema inemqx_rule_api_schema.erlto include the new event type.PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
changes/{ce,ee}/(feat|perf|fix)-<PR-id>.en.mdfilesChecklist for CI (.github/workflows) changes
changes/dir for user-facing artifacts update