Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: port the emqx_calendar from v4.4 #10747

Merged
merged 2 commits into from May 22, 2023

Conversation

lafirest
Copy link
Member

@lafirest lafirest commented May 19, 2023

Fixes EMQX-9847

Summary

馃 Generated by Copilot at a152fca

Refactor date and time functions in emqx_rule_funcs to use emqx_calendar for better performance and flexibility.

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Changed lines covered in coverage report
  • Change log has been added to changes/{ce,ee}/(feat|perf|fix)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • If there should be document changes, a PR to emqx-docs.git is sent, or a jira ticket is created to follow up
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

@lafirest lafirest marked this pull request as ready for review May 22, 2023 02:06
@lafirest lafirest requested review from a team and kjellwinblad as code owners May 22, 2023 02:06
Copy link
Member

@ieQu1 ieQu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to ignore the remarks, since this is a port. However, it would be nice to refactor this module in the future.

@lafirest lafirest merged commit 88e4078 into emqx:release-50 May 22, 2023
146 checks passed
@lafirest lafirest deleted the fix/rule_funs_time_offset branch May 22, 2023 12:52
@lafirest
Copy link
Member Author

Feel free to ignore the remarks, since this is a port. However, it would be nice to refactor this module in the future.

@ieQu1
Thanks for your review, I have created a ticket to update this module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants