feat(pulsar): ensure allocated resources are removed on failures (v5.0) #10778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thalesmg
force-pushed
the
refactor-pulsar-on-stop-v50
branch
from
44b87f0
to
188e9b6
Compare
paulozulato
previously approved these changes
May 22, 2023
thalesmg
force-pushed
the
refactor-pulsar-on-stop-v50
branch
2 times, most recently
from
fec3c27
to
8ad360d
Compare
paulozulato
previously approved these changes
May 23, 2023
thalesmg
force-pushed
the
refactor-pulsar-on-stop-v50
branch
8 times, most recently
from
37ae1dd
to
45055e9
Compare
thalesmg
force-pushed
the
refactor-pulsar-on-stop-v50
branch
from
45055e9
to
fd2940c
Compare
zmstone
approved these changes
May 24, 2023
| @@ -0,0 +1 @@ | |||
| Refactored Pulsar Producer bridge to avoid leaking resources during crashes. | |||
There was a problem hiding this comment.
Suggested change
| Refactored Pulsar Producer bridge to avoid leaking resources during crashes. | |
| Refactored Pulsar Producer bridge to avoid leaking resources during crashes at creation. |
There was a problem hiding this comment.
I'll correct this in the next PR refactoring on_stop, thanks.
Enhancements
|
增强
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://emqx.atlassian.net/browse/EMQX-9937
Summary
🤖 Generated by Copilot at 44b87f0
This pull request adds a new feature to the
emqx_bridge_pulsarmodule that uses theemqx_resourceAPI to allocate and free resources for each bridge instance. This improves the reliability and robustness of the Pulsar connector. It also adds test cases and modifies some ETS table operations to support this feature.PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
changes/{ce,ee}/(feat|perf|fix)-<PR-id>.en.mdfilesChecklist for CI (.github/workflows) changes
changes/dir for user-facing artifacts update