-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pulsar): ensure allocated resources are removed on failures (v5.0) #10778
Conversation
44b87f0
to
188e9b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fec3c27
to
8ad360d
Compare
37ae1dd
to
45055e9
Compare
45055e9
to
fd2940c
Compare
@@ -0,0 +1 @@ | |||
Refactored Pulsar Producer bridge to avoid leaking resources during crashes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refactored Pulsar Producer bridge to avoid leaking resources during crashes. | |
Refactored Pulsar Producer bridge to avoid leaking resources during crashes at creation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll correct this in the next PR refactoring on_stop
, thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed in #10813
Enhancements
|
增强
|
Fixes https://emqx.atlassian.net/browse/EMQX-9937
Summary
🤖 Generated by Copilot at 44b87f0
This pull request adds a new feature to the
emqx_bridge_pulsar
module that uses theemqx_resource
API to allocate and free resources for each bridge instance. This improves the reliability and robustness of the Pulsar connector. It also adds test cases and modifies some ETS table operations to support this feature.PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
changes/{ce,ee}/(feat|perf|fix)-<PR-id>.en.md
filesChecklist for CI (.github/workflows) changes
changes/
dir for user-facing artifacts update