fix: emqx_ctl traces ... command args
#10818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thalesmg
previously approved these changes
May 25, 2023
zhongwencool
previously approved these changes
May 26, 2023
* use second time as trace `start_at` and `end_at` * default trace time duration 30min to same as api created * prevent format line broken
zhongwencool
previously approved these changes
May 26, 2023
zhongwencool
approved these changes
May 26, 2023
Bug Fixes
|
修复
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes EMQX-9956
Summary
🤖 Generated by Copilot at ddd6198
This pull request fixes the
traces startcommand in theemqx_mgmt_climodule, which was not working properly with some filters. It also improves the output and the code quality of the module, and adds new test cases to verify the functionality.PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
changes/{ce,ee}/(feat|perf|fix)-<PR-id>.en.mdfilesIf there should be document changes, a PR to emqx-docs.git is sent, or a jira ticket is created to follow upSchema changes are backward compatibleChecklist for CI (.github/workflows) changes
If changed package build workflow, pass this action (manual trigger)changes/dir for user-facing artifacts update