Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: configurable TCP keepalive #10854

Merged
merged 3 commits into from May 29, 2023

Conversation

terry-xiaoyu
Copy link
Contributor

@terry-xiaoyu terry-xiaoyu commented May 29, 2023

Fixes

Summary

馃 Generated by Copilot at b548340

This pull request adds a new feature to configure TCP keepalive settings for MQTT connections, and improves the consistency, reliability, and testability of the code and configuration files. It modifies the etc/emqx.conf, priv/emqx.schema, src/emqx_connection.erl, src/emqx_zone.erl, and test/emqx_mqtt_SUITE.erl files to implement and test the feature. It also enhances the scripts/relup-base-packages.sh, scripts/macos-sign-binaries.sh, and scripts/split-config.escript files to support different package types, sign new binaries, and skip invalid configuration sections.

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Changed lines covered in coverage report
  • Change log has been added to changes/{ce,ee}/(feat|perf|fix)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • If there should be document changes, a PR to emqx-docs.git is sent, or a jira ticket is created to follow up
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

@terry-xiaoyu terry-xiaoyu requested review from a team, id and qzhuyan as code owners May 29, 2023 09:47
@terry-xiaoyu terry-xiaoyu changed the title chore: sync code from enterprise feat: configurable TCP keepalive May 29, 2023
@terry-xiaoyu terry-xiaoyu merged commit abbea11 into emqx:main-v4.4 May 29, 2023
11 checks passed
@terry-xiaoyu terry-xiaoyu deleted the sync-code-from-ee branch May 29, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant