Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactored some bridges to avoid leaking resources during crashes at creation #10895

Merged
merged 3 commits into from Jun 1, 2023

Conversation

lafirest
Copy link
Member

@lafirest lafirest commented May 31, 2023

Fixes EMQX-9939

Summary

🤖 Generated by Copilot at 6081ce8

This pull request refactors various connectors in the emqx_connector and emqx_bridge applications to use the emqx_resource module for managing their resources. This improves the resource management, consistency, reliability, and cleanup of the connectors.

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Changed lines covered in coverage report
  • Change log has been added to changes/{ce,ee}/(feat|perf|fix)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • If there should be document changes, a PR to emqx-docs.git is sent, or a jira ticket is created to follow up
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

@lafirest lafirest marked this pull request as ready for review June 1, 2023 06:41
@lafirest lafirest requested review from a team and JimMoen as code owners June 1, 2023 06:41
Copy link
Member

@HJianBo HJianBo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HJianBo HJianBo merged commit bcc5e30 into emqx:master Jun 1, 2023
166 checks passed
@lafirest lafirest deleted the fix/refactor_on_stop branch June 1, 2023 07:18
HJianBo added a commit to HJianBo/emqx that referenced this pull request Jun 5, 2023
@yanzhiemq
Copy link
Collaborator

yanzhiemq commented Jun 13, 2023

Enhancements

  • Refactored most of the bridges to avoid resource leaks during crashes during creation.

@yanzhiemq
Copy link
Collaborator

yanzhiemq commented Jun 13, 2023

增强

  • 重构了大部分桥接,以避免在创建过程中发生崩溃时的资源泄漏。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants