Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugins): use emqx:running_nodes for multicall operations #10913

Merged
merged 3 commits into from Jun 2, 2023

Conversation

thalesmg
Copy link
Contributor

@thalesmg thalesmg commented Jun 1, 2023

Fixes https://emqx.atlassian.net/browse/EMQX-10079

Summary

🤖 Generated by Copilot at a721b23

Added a new module emqx_mgmt_api_plugins_proto_v2 to support cluster-wide plugin management. Updated the emqx_mgmt_api_plugins module to use the new protocol and handle errors. Marked the emqx_mgmt_api_plugins_proto_v1 module as deprecated.

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Changed lines covered in coverage report
  • Change log has been added to changes/{ce,ee}/(feat|perf|fix)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • If there should be document changes, a PR to emqx-docs.git is sent, or a jira ticket is created to follow up
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

@thalesmg thalesmg force-pushed the fix-plugin-proto-multicall-v50 branch from a721b23 to 41e9b14 Compare June 1, 2023 16:59
@thalesmg thalesmg force-pushed the fix-plugin-proto-multicall-v50 branch from 41e9b14 to 7d3ce14 Compare June 1, 2023 17:00
@thalesmg thalesmg marked this pull request as ready for review June 1, 2023 18:00
@thalesmg thalesmg requested review from a team, JimMoen, lafirest and sstrigler as code owners June 1, 2023 18:00
@thalesmg thalesmg merged commit 2d7c1da into emqx:master Jun 2, 2023
166 checks passed
@thalesmg thalesmg deleted the fix-plugin-proto-multicall-v50 branch June 2, 2023 12:03
@yanzhiemq
Copy link
Collaborator

yanzhiemq commented Jun 13, 2023

Bug Fixes

  • Fixed an issue where the plugin status REST API of a node would still include the cluster node status after the node left the cluster.

@yanzhiemq
Copy link
Collaborator

yanzhiemq commented Jun 13, 2023

修复

  • 修复了某个节点离开集群后,其插件状态 REST API 仍会包含集群节点状态问题。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants