Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactor influxdb connector to to avoid resources leaking #10924

Merged
merged 1 commit into from Jun 5, 2023

Conversation

JimMoen
Copy link
Member

@JimMoen JimMoen commented Jun 2, 2023

Fixes EMQX-9935

Summary

🤖 Generated by Copilot at 85871a7

Refactor the emqx_bridge_influxdb_connector module to use the emqx_resource module and update the version and changelog. This improves the reliability and consistency of the influxdb bridge connector.

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Changed lines covered in coverage report
  • Change log has been added to changes/{ce,ee}/(feat|perf|fix)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • If there should be document changes, a PR to emqx-docs.git is sent, or a jira ticket is created to follow up
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

@JimMoen JimMoen requested a review from a team as a code owner June 2, 2023 10:26
changes/ee/feat-10923.en.md Outdated Show resolved Hide resolved
@JimMoen JimMoen force-pushed the refactor_influxdb_on_stop branch from 85871a7 to b1d62bf Compare June 2, 2023 16:56
@JimMoen JimMoen force-pushed the refactor_influxdb_on_stop branch from b1d62bf to a174d57 Compare June 3, 2023 18:21
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 5165053260

  • 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.008%) to 81.665%

Totals Coverage Status
Change from base Build 5159823271: 0.008%
Covered Lines: 28965
Relevant Lines: 35468

💛 - Coveralls

@HJianBo HJianBo requested review from zmstone and a team June 5, 2023 07:28
@JimMoen JimMoen merged commit 0f80834 into emqx:master Jun 5, 2023
132 checks passed
@JimMoen JimMoen deleted the refactor_influxdb_on_stop branch June 6, 2023 01:44
@yanzhiemq
Copy link
Collaborator

yanzhiemq commented Jun 13, 2023

Enhancements

  • Refactored Influxdb bridge connector to avoid resource leaks during crashes at creation.

@yanzhiemq
Copy link
Collaborator

yanzhiemq commented Jun 13, 2023

增强

  • 重构了 Influxdb 桥接,以避免在创建过程中出现资源泄漏的情况。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants