Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0602 add enable as an alias for enabled #10926

Merged

Conversation

zmstone
Copy link
Member

@zmstone zmstone commented Jun 2, 2023

Fixes EMQX-10126

Summary

🤖 Generated by Copilot at 04a4ad7

This pull request improves the listener schema and the configuration synchronization logic. It adds an alias for the enabled field in listener schemas, and enhances the log messages and the module organization in the sync_data_from_node function.

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Changed lines covered in coverage report
  • Change log has been added to changes/{ce,ee}/(feat|perf|fix)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • If there should be document changes, a PR to emqx-docs.git is sent, or a jira ticket is created to follow up
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

@zmstone zmstone requested review from a team and lafirest as code owners June 2, 2023 13:23
@zmstone zmstone force-pushed the 0602-add-enable-as-an-alias-for-enabled branch 2 times, most recently from 55aaaf9 to cac0093 Compare June 7, 2023 07:10
@zmstone zmstone force-pushed the 0602-add-enable-as-an-alias-for-enabled branch from cac0093 to 1e0b2de Compare June 7, 2023 18:31
@zmstone zmstone merged commit ee69783 into emqx:master Jun 9, 2023
132 checks passed
@zmstone zmstone deleted the 0602-add-enable-as-an-alias-for-enabled branch June 9, 2023 06:44
@yanzhiemq
Copy link
Collaborator

yanzhiemq commented Jun 13, 2023

Enhancements

  • Allowed 'enable' as well as 'enabled' as the state flag for listeners.

    Prior to this change, listener can be enable/disabled by setting the 'true' or 'false' on the 'enabled' config. This is slightly different naming comparing to other state flags in the system. No the 'enable' flag is added as an aliase on listeners.

@yanzhiemq
Copy link
Collaborator

yanzhiemq commented Jun 13, 2023

增强

  • 允许在监听器的状态标志中使用 "enable" 和 "enabled"。

    在此更改之前,可以通过在 "enabled" 配置上设置 "true" 或 "false" 来启用/禁用监听器。与系统中其他状态标志的命名略有不同。现在,添加了"enable" 标志作为监听器的别名。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants