Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tls): issue when ssl listner is configured to use tls v1.3 only #10983

Merged
merged 3 commits into from Jun 8, 2023

Conversation

id
Copy link
Collaborator

@id id commented Jun 8, 2023

Fixes https://emqx.atlassian.net/browse/EMQX-10192

Summary

🤖 Generated by Copilot at 2d79125

This pull request enhances the TLS support in emqx_tls_lib.erl by sorting and filtering the options based on the TLS version. It also adds unit tests for the new functionality in emqx_tls_lib_tests.erl.

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Changed lines covered in coverage report
  • Change log has been added to changes/{ce,ee}/(feat|perf|fix)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • If there should be document changes, a PR to emqx-docs.git is sent, or a jira ticket is created to follow up
  • Schema changes are backward compatible

@id id requested review from a team and lafirest as code owners June 8, 2023 13:03
clients could not connect due to incompatible tls options if ssl listner is configured to use tls v1.3 only
@id id force-pushed the 0608-handle-incompatible-tls-options branch from 380b5c4 to 3b0a389 Compare June 8, 2023 13:13
Copy link
Member

@zmstone zmstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update desc
e.g.
reuse_sessions.desc:
“”“Has no effect when TLS version is configured (or negotiated) to1.3""""

@id id force-pushed the 0608-handle-incompatible-tls-options branch from 3b0a389 to 0e0d7c1 Compare June 8, 2023 13:17
Copy link
Member

@zmstone zmstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe emqtt needs a check.

@id id merged commit 3a83328 into emqx:release-51 Jun 8, 2023
110 checks passed
@id id deleted the 0608-handle-incompatible-tls-options branch June 8, 2023 14:58
@id
Copy link
Collaborator Author

id commented Jun 8, 2023

maybe emqtt needs a check.

@zmstone emqx/emqtt#205

@yanzhiemq
Copy link
Collaborator

yanzhiemq commented Jun 13, 2023

Bug Fixes

  • Fixed the issue when mqtt clients could not connect over TLS if the listener was configured to use TLS v1.3 only.

    The problem was that TLS connection was trying to use options incompatible with TLS v1.3.

@yanzhiemq
Copy link
Collaborator

yanzhiemq commented Jun 13, 2023

修复

  • 修复了一个问题,即当 MQTT 客户端尝试通过配置为仅使用 TLS v1.3 的监听器进行连接时,无法建立TLS连接。

    问题在于 TLS 连接尝试使用与 TLS v1.3 不兼容的选项。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants