Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

0609 fix schema for dashboard use #10990

Merged
merged 1 commit into from
Jun 9, 2023

Conversation

zmstone
Copy link
Member

@zmstone zmstone commented Jun 9, 2023

Follow up fix for #10910

Summary

馃 Generated by Copilot at 38e767b

Added new types for timeout durations in emqx_conf. These types allow specifying the timeout units in seconds or milliseconds in the configuration schema.

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Changed lines covered in coverage report
  • Change log has been added to changes/{ce,ee}/(feat|perf|fix)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • If there should be document changes, a PR to emqx-docs.git is sent, or a jira ticket is created to follow up
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

@zmstone zmstone requested review from a team, kjellwinblad and lafirest as code owners June 9, 2023 07:17
@zmstone zmstone changed the base branch from master to release-51 June 9, 2023 07:18
@zmstone zmstone merged commit 643da05 into emqx:release-51 Jun 9, 2023
132 of 133 checks passed
@zmstone zmstone deleted the 0609-fix-schema-for-dashboard-use branch June 9, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants