Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: obfuscated the value of JWT #11019

Merged
merged 2 commits into from Jun 12, 2023

Conversation

lafirest
Copy link
Member

@lafirest lafirest commented Jun 12, 2023

Fixes EMQX-10242

Summary

🤖 Generated by Copilot at ba2e057

Added jwt as a sensitive key to is_sensitive_key function in emqx_utils.erl. This helps to mask sensitive information in logs and configs.

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Changed lines covered in coverage report
  • Change log has been added to changes/{ce,ee}/(feat|perf|fix)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • If there should be document changes, a PR to emqx-docs.git is sent, or a jira ticket is created to follow up
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

@lafirest lafirest marked this pull request as ready for review June 12, 2023 09:31
@lafirest lafirest requested a review from a team as a code owner June 12, 2023 09:31
@lafirest lafirest marked this pull request as draft June 12, 2023 09:36
@lafirest lafirest marked this pull request as ready for review June 12, 2023 10:02
@lafirest lafirest merged commit e78b7c5 into emqx:release-51 Jun 12, 2023
40 checks passed
@lafirest lafirest deleted the fix/dua_konservi_sentema branch June 12, 2023 10:10
@yanzhiemq
Copy link
Collaborator

yanzhiemq commented Jun 13, 2023

Enhancements

  • Improved log security for JWT, now it will be obfuscated before print.

@yanzhiemq
Copy link
Collaborator

yanzhiemq commented Jun 13, 2023

增强

  • 改进了JWT 的日志安全性,现在在打印之前将进行模糊化处理。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants