feat(pulsar): retry health check a bit before returning (r5.1) #11024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes https://emqx.atlassian.net/browse/EMQX-10228 This is a cosmetic fix for the Pulsar Producer bridge health check status. Pulsar connection process is asynchronous, therefore, when a bridge of this type is created or updated (which is the same as stopping and re-creating it), the immediate status will be connecting because it’s indeed still connecting. The bridge will connect very soon afterwards (assuming there are no true network/config issue), but having to refresh the UI to see the new status and/or seeing the resource alarm might annoy users. This workaround adds a few retries to account for that effect to reduce the probability of seeing the `connecting` state on such happy-paths.
thalesmg
force-pushed
the
pulsar-cosmetic-connecting-check-r51
branch
from
39ea2c8
to
db5d14d
Compare
zhongwencool
approved these changes
Jun 12, 2023
Enhancements
|
增强
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
targeting
release-51Fixes https://emqx.atlassian.net/browse/EMQX-10228
This is a cosmetic fix for the Pulsar Producer bridge health check status.
Pulsar connection process is asynchronous, therefore, when a bridge of this type is created or updated (which is the same as stopping and re-creating it), the immediate status will be connecting because it’s indeed still connecting. The bridge will connect very soon afterwards (assuming there are no true network/config issue), but having to refresh the UI to see the new status and/or seeing the resource alarm might annoy users.
This workaround adds a few retries to account for that effect to reduce the probability of seeing the
connectingstate on such happy-paths.After patch:
Peek.2023-06-12.11-05.mp4
Summary
🤖 Generated by Copilot at 39ea2c8
Improve health check for emqx bridge pulsar plugin by adding a retry timeout and using a macro. Change
emqx_bridge_pulsar_impl_producer.erlfile.PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
changes/{ce,ee}/(feat|perf|fix)-<PR-id>.en.mdfilesChecklist for CI (.github/workflows) changes
changes/dir for user-facing artifacts update