Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(influxdb): check authentication #11031

Merged
merged 1 commit into from Jun 14, 2023

Conversation

paulozulato
Copy link
Contributor

@paulozulato paulozulato commented Jun 13, 2023

targeting release-51

Checks authentication on bridge start and get status. Also, handle authentication error when sending message.

Fixes https://emqx.atlassian.net/browse/EMQX-10213

Summary

🤖 Generated by Copilot at 410faba

This pull request enhances the security and error handling of the emqx_bridge_influxdb connector by adding authentication checks and 401 error handling. It also adds test cases to verify the functionality and the expected logs and events. It modifies the emqx_bridge_influxdb_connector.erl and emqx_bridge_influxdb_SUITE.erl files.

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Changed lines covered in coverage report
  • Change log has been added to changes/{ce,ee}/(feat|perf|fix)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • If there should be document changes, a PR to emqx-docs.git is sent, or a jira ticket is created to follow up
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

@paulozulato paulozulato marked this pull request as ready for review June 13, 2023 13:28
@paulozulato paulozulato requested a review from a team as a code owner June 13, 2023 13:28
Checks authentication on bridge start and get status. Also, handle
authentication error when sending message.

Fixes https://emqx.atlassian.net/browse/EMQX-10213
Copy link
Contributor

@thalesmg thalesmg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: how does this look like in the frontend?

@paulozulato
Copy link
Contributor Author

you'll get the following message when trying to connect using wrong credentials:

image

@paulozulato paulozulato merged commit 36d6350 into emqx:release-51 Jun 14, 2023
116 checks passed
@yanzhiemq
Copy link
Collaborator

yanzhiemq commented Jun 15, 2023

Bug Fixes

  • Fixed credential validation when creating bridge and checking status for InfluxDB Bridges.

@yanzhiemq
Copy link
Collaborator

yanzhiemq commented Jun 15, 2023

修复

  • 修复了创建桥接和检查 InfluxDB 桥接时的认证信息验证问题。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants