Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(emqx_connector): report errors in on_start handler #11037

Conversation

sstrigler
Copy link
Contributor

@sstrigler sstrigler commented Jun 13, 2023

Fixes EMQX-10174

This PR fixes the HTTP connector for webhooks and IoTDB. There will be a follow up for kafka.

Summary

馃 Generated by Copilot at 8804560

This pull request improves the test code and the error handling of the emqx_bridge and emqx_connector applications. It refactors the emqx_bridge_testlib and emqx_bridge_webhook_SUITE modules to make them more readable and robust. It also fixes a bug in the emqx_connector_http module that caused the connector to report a wrong status when the HTTP connection failed.

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Changed lines covered in coverage report
  • Change log has been added to changes/{ce,ee}/(feat|perf|fix)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • If there should be document changes, a PR to emqx-docs.git is sent, or a jira ticket is created to follow up
  • Schema changes are backward compatible

@sstrigler sstrigler force-pushed the EMQX-10174-e-5-1-0-reconnect-does-not-show-any-errors-for-apache-io-tdb-or-webhook-or-kafka branch from 8804560 to d2f4e8c Compare June 13, 2023 14:20
@sstrigler sstrigler force-pushed the EMQX-10174-e-5-1-0-reconnect-does-not-show-any-errors-for-apache-io-tdb-or-webhook-or-kafka branch from d2f4e8c to b2a5065 Compare June 13, 2023 14:57
@coveralls
Copy link
Collaborator

coveralls commented Jun 14, 2023

Pull Request Test Coverage Report for Build 5264714003

  • 10 of 15 (66.67%) changed or added relevant lines in 1 file are covered.
  • 21 unchanged lines in 6 files lost coverage.
  • Overall coverage increased (+0.08%) to 81.968%

Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/emqx_connector/src/emqx_connector_http.erl 10 15 66.67%
Files with Coverage Reduction New Missed Lines %
apps/emqx/src/emqx_broker.erl 1 88.2%
apps/emqx/src/emqx_channel.erl 1 87.86%
apps/emqx/src/emqx_logger.erl 1 80.49%
apps/emqx/src/emqx_message.erl 1 94.83%
apps/emqx/src/emqx_flapping.erl 3 85.48%
apps/emqx/src/emqx_reason_codes.erl 14 87.5%
Totals Coverage Status
Change from base Build 5244853575: 0.08%
Covered Lines: 29737
Relevant Lines: 36279

馃挍 - Coveralls

@sstrigler sstrigler marked this pull request as ready for review June 14, 2023 08:16
@sstrigler sstrigler requested review from a team and JimMoen as code owners June 14, 2023 08:16
@sstrigler sstrigler merged commit bf62cdc into emqx:master Jun 14, 2023
131 checks passed
@sstrigler sstrigler deleted the EMQX-10174-e-5-1-0-reconnect-does-not-show-any-errors-for-apache-io-tdb-or-webhook-or-kafka branch October 25, 2023 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants