Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(emqx_schema): use non negative integer type for 'depth' SSL option #11051

Merged

Conversation

SergeTupchiy
Copy link
Contributor

@SergeTupchiy SergeTupchiy commented Jun 14, 2023

Fixes EMQX-10276

Summary

🤖 Generated by Copilot at bfad459

Fixed a bug that prevented EMQ X broker from starting with SSL/TLS when the certificate chain depth was negative. Added a unit test for the server_ssl_opts_schema function to check the depth field validation.

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Changed lines covered in coverage report
  • Change log has been added to changes/{ce,ee}/(feat|perf|fix)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • If there should be document changes, a PR to emqx-docs.git is sent, or a jira ticket is created to follow up
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

@SergeTupchiy SergeTupchiy requested review from a team and lafirest as code owners June 14, 2023 15:57
@SergeTupchiy SergeTupchiy force-pushed the EMQX-10276-validate-cert-depth branch from bfad459 to dd20bb4 Compare June 14, 2023 16:03
zhongwencool
zhongwencool previously approved these changes Jun 15, 2023
apps/emqx/src/emqx_schema.erl Show resolved Hide resolved
@SergeTupchiy SergeTupchiy merged commit c269079 into emqx:master Jun 15, 2023
127 of 128 checks passed
@yanzhiemq
Copy link
Collaborator

yanzhiemq commented Jun 18, 2023

Bug Fixes

  • Added validation to ensure that certificate depth (listener SSL option) is a non negative integer.

@yanzhiemq
Copy link
Collaborator

yanzhiemq commented Jun 18, 2023

修复

  • 增加了对证书层级(监听器 SSL 选项)须为非负整数的验证。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants