Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rename log.file.to to log.file.path #11062

Merged
merged 2 commits into from Jun 15, 2023

Conversation

zhongwencool
Copy link
Member

@zhongwencool zhongwencool commented Jun 15, 2023

Fixes

Summary

🤖 Generated by Copilot at 4dfe3c5

Renamed to key to path in log_file_handler config and updated schema, tests, and config builder accordingly. This improves clarity and consistency of the config format and eases migration.

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Changed lines covered in coverage report
  • Change log has been added to changes/{ce,ee}/(feat|perf|fix)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • If there should be document changes, a PR to emqx-docs.git is sent, or a jira ticket is created to follow up
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

@zhongwencool zhongwencool merged commit 9b56f11 into emqx:release-51 Jun 15, 2023
109 checks passed
@zhongwencool zhongwencool deleted the log-file-rename branch June 15, 2023 12:52
@yanzhiemq
Copy link
Collaborator

yanzhiemq commented Jun 18, 2023

Enhancements

  • Renamed log.file.to to log.file.path.

@yanzhiemq
Copy link
Collaborator

yanzhiemq commented Jun 18, 2023

增强

  • log.file.to 更名为 log.file.path

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants