Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add range validation for max_clientid_len #11096

Merged
merged 1 commit into from Jun 20, 2023

Conversation

terry-xiaoyu
Copy link
Contributor

@terry-xiaoyu terry-xiaoyu commented Jun 20, 2023

Fixes

Summary

馃 Generated by Copilot at 38d92c9

Add a new validator for MQTT client identifier lengths and use it in emqx.schema. This ensures that the configuration option mqtt.max_clientid_len is within the valid range of 23 to 65535.

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Changed lines covered in coverage report
  • Change log has been added to changes/{ce,ee}/(feat|perf|fix)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • If there should be document changes, a PR to emqx-docs.git is sent, or a jira ticket is created to follow up
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

@terry-xiaoyu terry-xiaoyu requested a review from a team as a code owner June 20, 2023 02:31
@terry-xiaoyu terry-xiaoyu merged commit 21797d8 into release-v44 Jun 20, 2023
134 of 135 checks passed
@terry-xiaoyu terry-xiaoyu deleted the range_validator_max_clientid_len branch June 20, 2023 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants