Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(resource): validate maximum worker pool size #11106

Merged
merged 1 commit into from Jun 20, 2023

Conversation

thalesmg
Copy link
Contributor

@thalesmg thalesmg commented Jun 20, 2023

Fixes https://emqx.atlassian.net/browse/EMQX-10297

After fix:

image

Summary

馃 Generated by Copilot at 1d791d7

Fixed the validation of worker_pool_size for bridge resources to prevent excessive memory consumption and performance issues. Added tests and changelog entry for the fix.

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Changed lines covered in coverage report
  • Change log has been added to changes/{ce,ee}/(feat|perf|fix)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • If there should be document changes, a PR to emqx-docs.git is sent, or a jira ticket is created to follow up
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

@thalesmg thalesmg force-pushed the fix-validate-worker-pool-size-master branch from 5536e6a to 1d791d7 Compare June 20, 2023 17:26
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 5325613113

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 32 unchanged lines in 12 files lost coverage.
  • Overall coverage increased (+0.02%) to 81.75%

Files with Coverage Reduction New Missed Lines %
apps/emqx_gateway_mqttsn/src/emqx_mqttsn_frame.erl 1 64.61%
apps/emqx_modules/src/emqx_delayed.erl 1 94.78%
apps/emqx/src/emqx_channel.erl 1 87.86%
apps/emqx/src/emqx_config.erl 1 88.61%
apps/emqx/src/emqx_config_handler.erl 1 96.91%
apps/emqx/src/emqx_session.erl 1 87.65%
apps/emqx/src/emqx_alarm.erl 2 89.92%
apps/emqx/src/emqx_cm.erl 2 92.05%
apps/emqx/src/emqx_stats.erl 2 91.67%
apps/emqx_utils/src/emqx_utils.erl 2 80.23%
Totals Coverage Status
Change from base Build 5322820459: 0.02%
Covered Lines: 29873
Relevant Lines: 36542

馃挍 - Coveralls

@thalesmg thalesmg marked this pull request as ready for review June 20, 2023 18:19
@thalesmg thalesmg requested a review from a team as a code owner June 20, 2023 18:19
@thalesmg thalesmg merged commit 010c2fb into emqx:master Jun 20, 2023
131 checks passed
@thalesmg thalesmg deleted the fix-validate-worker-pool-size-master branch June 20, 2023 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants