Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(rule_engine): improve the time offset parser #11135

Merged
merged 2 commits into from Jun 26, 2023

Conversation

lafirest
Copy link
Member

@lafirest lafirest commented Jun 24, 2023

Fixes EMQX-9969

Summary

馃 Generated by Copilot at c8c2793

Refactor emqx_calendar.erl to enhance readability and style.

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Changed lines covered in coverage report
  • Change log has been added to changes/{ce,ee}/(feat|perf|fix)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • If there should be document changes, a PR to emqx-docs.git is sent, or a jira ticket is created to follow up
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

@lafirest lafirest marked this pull request as ready for review June 24, 2023 13:13
@lafirest lafirest requested a review from a team as a code owner June 24, 2023 13:13
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 5364499479

  • 8 of 10 (80.0%) changed or added relevant lines in 1 file are covered.
  • 28 unchanged lines in 9 files lost coverage.
  • Overall coverage decreased (-0.004%) to 81.683%

Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/emqx/src/emqx_calendar.erl 8 10 80.0%
Files with Coverage Reduction New Missed Lines %
apps/emqx_dashboard/src/emqx_dashboard_desc_cache.erl 1 94.44%
apps/emqx_dashboard/src/emqx_dashboard_monitor.erl 1 66.21%
apps/emqx_gateway/src/emqx_gateway_schema.erl 1 94.44%
apps/emqx/src/emqx_broker.erl 1 88.2%
apps/emqx/src/emqx_cm.erl 1 92.05%
apps/emqx/src/emqx_metrics.erl 1 88.21%
apps/emqx/src/emqx_ocsp_cache.erl 1 82.53%
apps/emqx_oracle/src/emqx_oracle.erl 4 80.0%
apps/emqx/src/emqx_reason_codes.erl 17 85.29%
Totals Coverage Status
Change from base Build 5356448716: -0.004%
Covered Lines: 30217
Relevant Lines: 36993

馃挍 - Coveralls

@lafirest lafirest merged commit f2e3446 into emqx:master Jun 26, 2023
118 of 119 checks passed
@lafirest lafirest deleted the pref/calendar_timeoffset branch June 26, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants