refactor: MySQL bridge and connector to separate applications #11151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit refactor the MySQL bridge to its own application. Fixes: https://emqx.atlassian.net/browse/EMQX-9533
kjellwinblad
requested review from
a team,
JimMoen and
savonarola
as code owners
savonarola
previously approved these changes
Jun 27, 2023
Pull Request Test Coverage Report for Build 5397791914
馃挍 - Coveralls |
savonarola
approved these changes
Jun 28, 2023
id
reviewed
Jul 4, 2023
There was a problem hiding this comment.
this file should be removed, mysql connector is ee only feature
also see similar comment for redis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactor the MySQL bridge and the connector to separate applications.
Fixes:
https://emqx.atlassian.net/browse/EMQX-9533
Summary
馃 Generated by Copilot at 3d1712c
This pull request introduces a new
emqx_mysqlapplication that implements a MySQL connector for EMQ X. It also updates the existingemqx_authn,emqx_authz, andemqx_bridge_mysqlapplications to use the new connector API and fixes some bugs and refactors some code. It removes the MySQL connector from theemqx_connectorapplication and updates the documentation and tests accordingly.PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
changes/{ce,ee}/(feat|perf|fix)-<PR-id>.en.mdfiles