Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: hide /configs/limiter from swagger api doc #11165

Merged

Conversation

zhongwencool
Copy link
Member

@zhongwencool zhongwencool commented Jun 30, 2023

Fixes https://emqx.atlassian.net/browse/EMQX-10463

Summary

馃 Generated by Copilot at 3eefa1b

Hide password fields of some authentication schemas in API and dashboard. This improves security by avoiding exposing sensitive credentials in emqx_mgmt_api_configs.erl.

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Changed lines covered in coverage report
  • Change log has been added to changes/{ce,ee}/(feat|perf|fix)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • If there should be document changes, a PR to emqx-docs.git is sent, or a jira ticket is created to follow up
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

@zhongwencool zhongwencool requested review from a team, lafirest and sstrigler as code owners June 30, 2023 02:59
@zhongwencool zhongwencool merged commit bb1ae80 into emqx:master Jun 30, 2023
139 of 140 checks passed
@zhongwencool zhongwencool deleted the hide-global-limiter-from-swagger-api branch June 30, 2023 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants