New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ruleengine): fix duplicate payload
problems
#11172
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lafirest
commented
Jun 30, 2023
?ephemeral_alias(unknown, unknown). | ||
|
||
handle_path_alias({path, [{key, <<"payload">>} | Rest]}, #{payload := _Payload} = _Columns) -> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make sure the payload
in the path has the same type as it in the columns or it possibly be duplicated
lafirest
force-pushed
the
fix/dup_payload
branch
3 times, most recently
from
July 3, 2023 08:47
c7e91e0
to
cd4e421
Compare
HJianBo
approved these changes
Jul 5, 2023
lafirest
added a commit
to lafirest/emqx
that referenced
this pull request
Jul 24, 2023
lafirest
added a commit
that referenced
this pull request
Jul 24, 2023
fix(nested_put): fix a data loss bug introduced by #11172
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes EMQX-10197
Summary
馃 Generated by Copilot at 95973a3
Added path aliases for SQL queries in rule engine. This allows users to refer to nested payload fields with shorter names in the
SELECT
clause. Refactored some internal functions inemqx_rule_runtime.erl
to support this feature.PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
changes/{ce,ee}/(feat|perf|fix)-<PR-id>.en.md
filesChecklist for CI (.github/workflows) changes
changes/
dir for user-facing artifacts update