Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: influxdb float serialization error #11223

Merged
merged 2 commits into from Jul 10, 2023

Conversation

JimMoen
Copy link
Member

@JimMoen JimMoen commented Jul 7, 2023

Fixes EMQX-10509

Summary

馃 Generated by Copilot at 4a7ba95

Fix a bug in emqx_bridge_influxdb_connector that caused serialization errors when writing integers as floats to the InfluxDB bridge. Add a changelog file fix-11223.en.md to document the bug fix.

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Changed lines covered in coverage report
  • Change log has been added to changes/{ce,ee}/(feat|perf|fix)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • If there should be document changes, a PR to emqx-docs.git is sent, or a jira ticket is created to follow up
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

@JimMoen JimMoen requested a review from a team as a code owner July 7, 2023 09:43
@JimMoen JimMoen marked this pull request as draft July 7, 2023 09:47
@JimMoen JimMoen force-pushed the fix-influxdb-float-value-trans branch from 4a7ba95 to b7d880f Compare July 10, 2023 10:52
@JimMoen JimMoen marked this pull request as ready for review July 10, 2023 10:52
@JimMoen JimMoen force-pushed the fix-influxdb-float-value-trans branch from b7d880f to a46f0c4 Compare July 10, 2023 10:57
@JimMoen JimMoen force-pushed the fix-influxdb-float-value-trans branch from a46f0c4 to e30bc6a Compare July 10, 2023 12:00
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 5507784632

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 20 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+0.04%) to 82.301%

Files with Coverage Reduction New Missed Lines %
apps/emqx_conf/src/emqx_conf_schema.erl 1 94.74%
apps/emqx_gateway_mqttsn/src/emqx_mqttsn_channel.erl 1 73.69%
apps/emqx_gateway/src/emqx_gateway_utils.erl 1 85.81%
apps/emqx_resource/src/emqx_resource_buffer_worker.erl 2 93.26%
apps/emqx_gateway_exproto/src/emqx_exproto_gsvr.erl 3 67.27%
apps/emqx_gateway/src/emqx_gateway_cm.erl 3 77.88%
apps/emqx/src/emqx_reason_codes.erl 9 88.97%
Totals Coverage Status
Change from base Build 5506845904: 0.04%
Covered Lines: 30945
Relevant Lines: 37600

馃挍 - Coveralls

Copy link
Member

@HJianBo HJianBo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HJianBo HJianBo requested a review from savonarola July 10, 2023 13:41
@HJianBo HJianBo merged commit ae59a26 into emqx:master Jul 10, 2023
138 checks passed
@JimMoen JimMoen deleted the fix-influxdb-float-value-trans branch July 10, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants