fix(bridge): ensure the username of pgsql must exists #11225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lafirest
force-pushed
the
fix/pgsql_function_clause
branch
from
7170102
to
d01eee7
Compare
savonarola
reviewed
Jul 7, 2023
| emqx_connector_schema_lib:ssl_fields() ++ | ||
| emqx_connector_schema_lib:prepare_statement_fields(). | ||
|
|
||
| server() -> | ||
| Meta = #{desc => ?DESC("server")}, | ||
| emqx_schema:servers_sc(Meta, ?PGSQL_HOST_OPTIONS). | ||
|
|
||
| adjust_fields(Fields) -> |
There was a problem hiding this comment.
Suggested change
| adjust_fields(Fields) -> | |
| adjust_username_field(Fields) -> |
savonarola
approved these changes
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes EMQX-10382
Summary
馃 Generated by Copilot at 8cee751
Fixed a PostgreSQL connector bug and added a helper function. The bug prevented connecting to PostgreSQL with empty
usernamefields, and the helper functionadjust_fieldsinemqx_connector_pgsql.erlhandles this case.PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
changes/{ce,ee}/(feat|perf|fix)-<PR-id>.en.mdfilesChecklist for CI (.github/workflows) changes
changes/dir for user-facing artifacts update