New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: alias listeners.Type.Name.enabled as listeners.Type.Name.enable #11226
Merged
HJianBo
merged 4 commits into
emqx:master
from
zhongwencool:listener-conf-enabled-to-enable
Jul 10, 2023
Merged
fix: alias listeners.Type.Name.enabled as listeners.Type.Name.enable #11226
HJianBo
merged 4 commits into
emqx:master
from
zhongwencool:listener-conf-enabled-to-enable
Jul 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thalesmg
previously approved these changes
Jul 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add a changelog?
zhongwencool
force-pushed
the
listener-conf-enabled-to-enable
branch
from
July 7, 2023 13:28
5c07980
to
eb3d359
Compare
Done |
zhongwencool
force-pushed
the
listener-conf-enabled-to-enable
branch
2 times, most recently
from
July 7, 2023 22:52
c2e9a77
to
d7ce077
Compare
zhongwencool
force-pushed
the
listener-conf-enabled-to-enable
branch
from
July 10, 2023 02:34
d7ce077
to
d661b10
Compare
Pull Request Test Coverage Report for Build 5503397754
馃挍 - Coveralls |
id
approved these changes
Jul 10, 2023
HJianBo
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://emqx.atlassian.net/browse/EMQX-10501
listeners.tcp.x
uses "enabled" as primary key(enable as alias) for backwards compatibilitySummary
馃 Generated by Copilot at 5c07980
This pull request standardizes the
enable
key name in the listener configuration map across different API endpoints and files. It also fixes some typos and renames the schema file to match the module name.PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
changes/{ce,ee}/(feat|perf|fix)-<PR-id>.en.md
filesChecklist for CI (.github/workflows) changes
changes/
dir for user-facing artifacts update