Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugins): start/stop plugins when loading config from CLI #11229

Merged
merged 1 commit into from Jul 7, 2023

Conversation

thalesmg
Copy link
Contributor

@thalesmg thalesmg commented Jul 7, 2023

Fixes https://emqx.atlassian.net/browse/EMQX-10288

Summary

馃 Generated by Copilot at 2740bb6

Added support for dynamic plugin configuration via CLI in emqx_plugins. Implemented a config handler and a test case for this feature. Bumped the version of emqx_plugins to 0.1.5.

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Changed lines covered in coverage report
  • Change log has been added to changes/(ce|ee)/(feat|perf|fix)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • If there should be document changes, a PR to emqx-docs.git is sent, or a jira ticket is created to follow up
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

@thalesmg thalesmg force-pushed the fix-plugin-load-conf-master branch from 2740bb6 to 6337f52 Compare July 7, 2023 16:37
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 5488604133

  • 11 of 13 (84.62%) changed or added relevant lines in 2 files are covered.
  • 22 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+0.02%) to 82.307%

Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/emqx_plugins/src/emqx_plugins.erl 9 11 81.82%
Files with Coverage Reduction New Missed Lines %
apps/emqx_resource/src/emqx_resource_buffer_worker.erl 1 93.68%
apps/emqx/src/emqx_channel.erl 1 87.71%
apps/emqx/src/emqx_limiter/src/emqx_limiter_schema.erl 1 81.48%
apps/emqx/src/emqx_session.erl 1 87.65%
apps/emqx_gateway_mqttsn/src/emqx_mqttsn_frame.erl 2 64.04%
apps/emqx_oracle/src/emqx_oracle.erl 4 80.0%
apps/emqx/src/emqx_reason_codes.erl 12 88.97%
Totals Coverage Status
Change from base Build 5488419108: 0.02%
Covered Lines: 30945
Relevant Lines: 37597

馃挍 - Coveralls

@thalesmg thalesmg marked this pull request as ready for review July 7, 2023 18:36
@thalesmg thalesmg requested review from a team and JimMoen as code owners July 7, 2023 18:36
@thalesmg thalesmg merged commit 0d1abf7 into emqx:master Jul 7, 2023
138 checks passed
@thalesmg thalesmg deleted the fix-plugin-load-conf-master branch July 7, 2023 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants