Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bad prometheus schema for headers #11237

Merged
merged 3 commits into from Jul 10, 2023

Conversation

zhongwencool
Copy link
Member

@zhongwencool zhongwencool commented Jul 10, 2023

Fixes

  1. default headers should be a empty map, not a empty list.
  2. Plain-text should be displayed with priority, json will be deprecated soon.
image image

Summary

馃 Generated by Copilot at 75cad5e

This pull request fixes a bug in the prometheus api openapi spec, simplifies the headers config for the prometheus push gateway, and updates the emqx_prometheus version number.

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Changed lines covered in coverage report
  • Change log has been added to changes/(ce|ee)/(feat|perf|fix)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • If there should be document changes, a PR to emqx-docs.git is sent, or a jira ticket is created to follow up
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

@zhongwencool zhongwencool requested review from a team and JimMoen as code owners July 10, 2023 08:35
@zhongwencool zhongwencool merged commit f9e54ed into emqx:master Jul 10, 2023
138 checks passed
@zhongwencool zhongwencool deleted the prometheus-api-schema branch July 10, 2023 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants