refactor: HTTP bridge into the emqx_bridge_http application #11253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
id
requested review from
a team,
lafirest,
sstrigler,
JimMoen and
savonarola
as code owners
5 tasks
thalesmg
reviewed
Jul 11, 2023
thalesmg
reviewed
Jul 11, 2023
thalesmg
previously approved these changes
Jul 11, 2023
qzhuyan
previously approved these changes
Jul 12, 2023
id
force-pushed
the
kjell/refactor/http_bridge/EMQX-9568
branch
from
e3a8e54
to
157ec22
Compare
id
force-pushed
the
kjell/refactor/http_bridge/EMQX-9568
branch
from
157ec22
to
4175125
Compare
```
===> Compiling emqx_machine
===> Compiling src/user_default.erl failed
src/user_default.erl:{24,14}: can't find include lib "emqx_dashboard/include/emqx_dashboard.hrl"; Make sure emqx_dashboard is in your app file's 'applications' list
==> emqx_mix
** (Mix) Could not compile dependency :emqx_machine, "/github/home/.mix/elixir/1-14/rebar3 bare compile --paths /__w/emqx/emqx/_build/emqx/lib/*/ebin" command failed. Errors may have been logged above. You can recompile this dependency with "mix deps.compile emqx_machine", update it with "mix deps.update emqx_machine" or clean it with "mix deps.clean emqx_machine"
make: *** [Makefile:276: emqx-elixir] Error 1
```
id
force-pushed
the
kjell/refactor/http_bridge/EMQX-9568
branch
from
4175125
to
6180e77
Compare
thalesmg
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://emqx.atlassian.net/browse/EMQX-9568
Summary
🤖 Generated by Copilot at c3cf619
Refactor the HTTP bridge and connector features by moving them to a separate application
emqx_bridge_http, and update the dependencies and references of other applications that use them. Rename the modulesemqx_connector_httpandemqx_bridge_webhook_schematoemqx_bridge_http_connectorandemqx_bridge_http_schemarespectively, to avoid confusion and reflect the new application structure. Add documentation, testing, and configuration files for the new application.PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
changes/(ce|ee)/(feat|perf|fix)-<PR-id>.en.mdfiles