fix(tdengine): fix SQL template errors #11266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. supports multi-table insert 2. supports constructing subtable names by mixed prefixes and placeholders
paulozulato
previously approved these changes
Jul 13, 2023
|
|
||
| `insert into table_${topic} values (${ts}, '${id}', '${topic}')` | ||
|
|
||
| Note: This is a breaking change, at the former, the string-type values are automatically quoted, bu now, you should manually quote them. |
| fun({Table, Size}) -> | ||
| ?assertMatch( | ||
| [[Size]], | ||
| connect_and_query(Config, "SELECT COUNT(1) FROM " ++ Table) |
There was a problem hiding this comment.
nit: you changed from SELECT COUNT(1) to SELECT 1 on line 489. Maybe use it here as well?
thalesmg
previously approved these changes
Jul 13, 2023
Co-authored-by: Thales Macedo Garitezi <thalesmg@gmail.com>
thalesmg
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes EMQX-10545
Summary
馃 Generated by Copilot at fef5087
Refactored and simplified the SQL placeholder processing logic in
emqx_bridge_tdengine_connector.erl. Renamed a function for clarity.PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
changes/(ce|ee)/(feat|perf|fix)-<PR-id>.en.mdfilesChecklist for CI (.github/workflows) changes
changes/dir for user-facing artifacts update